Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update calls to insertInFile to patchInFile #987

Merged
merged 2 commits into from
Apr 21, 2017
Merged

Update calls to insertInFile to patchInFile #987

merged 2 commits into from
Apr 21, 2017

Conversation

ryanlntn
Copy link
Member

Please verify the following:

  • Everything works on iOS/Android
  • npm test ava tests pass with new tests, if relevant

Next step will be moving patchInFile up into gluegun.

@jamonholmgren jamonholmgren merged commit 1301d85 into master Apr 21, 2017
@jamonholmgren jamonholmgren deleted the insert-to-patch branch April 21, 2017 22:46
@jamonholmgren jamonholmgren mentioned this pull request Apr 21, 2017
Closed
@skellock
Copy link
Contributor

@ryanlntn I can show you how that's done next week if ya like? Would only take like 10 mins.

@ryanlntn
Copy link
Member Author

@skellock Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamonholmgren jamonholmgren jamonholmgren approved these changes

@GantMan GantMan Awaiting requested review from GantMan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanlntn @skellock @jamonholmgren