Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Tour of Ignite documentation, updates other docs #989

Merged
merged 1 commit into from
Apr 24, 2017

Conversation

jamonholmgren
Copy link
Member

Also removes old testRelease.sh script

Also removes old testRelease.sh script
Copy link
Contributor

@skellock skellock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful doc! Optional nitpicks included here. You don't have to add them if you don't want.


In addition, Ignite adds some of its own Ignite-specific functions and parameters to `context` ... those are found under `context.ignite`.

If you're curious what's in the context object, check out Gluegun's [nice context docs](https://infinitered.github.io/gluegun/#/context-api.md), or just inspect it with `console.dir(context, {depth: 3, colors true})`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah. i never knew about depth: 3, colors: true.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither did I. I literally looked up console.dir to find out what the frig it was, since I'd seen you use it a lot.

https://nodejs.org/api/console.html#console_console_dir_obj_options

Lots of cool stuff.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's funny was, I've often wanted a depth setting! I just never had the presence of mind to look up the docs. Nice tip. Thx.


#### Extensions

Any file exports in this directory will get automatically added to the `context` object as additional properties. Let's say we wanted a `context.foo()` function. Just add `foo.js` into `./src/extensions` and export a function from there. You'll then be able to access it anywhere as `context.foo()`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a note about how we often use extensions for namespacing or organizing?

@skellock skellock merged commit a362a8d into master Apr 24, 2017
@skellock skellock deleted the docs/tour-of-ignite branch April 24, 2017 00:36
ryanlntn added a commit that referenced this pull request Apr 24, 2017
* master: (138 commits)
  Minor fixes to tour documentation per @skellock (#990)
  Adds Tour of Ignite documentation, updates other docs (#989)
  Adds getting started instructions to CONTRIBUTING.md
  Fix syntax error
  Update calls to insertInFile to patchInFile
  Update Readme to include Plugins link - change emojis (#982)
  Add a couple links to React Native's Getting Started page (#981)
  Add clarification about final npm install command after saying to install Yarn (#976)
  Adds links to 2 new ignite plugins.
  References proper react-native binary - Fixes #949 (#972)
  Adds a test to back up the new gluegun module loading.
  Adds gluegun plugin detection.
  Feel the love (#965)
  fix-flash-on-navigation-transitions: cardStyle fixes for white screen on transition (#969)
  Update third party plugins list to table (#963)
  add source map to list (#959)
  Updating creating-plugins doc and plugin.js.ejs (#958)
  Update README.md
  Add README section about premium support (#947)
  Fix document typo
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants