Added trailing slash to Buffer import in index.ts #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As recommended by the [Buffer maintainer](https://github.com/feross/buffer?tab=readme-ov-file#usage): >To require this module explicitly, use require('buffer/') which tells the node.js module lookup algorithm (also used by browserify) to use the npm module named buffer instead of the node.js core module named buffer! This solves a bug found bundling NSFWJS with Bun. ``` Build failed 1 | import { Buffer } from 'buffer'; ^ error: No matching export in "node:buffer" for import "Buffer" at [path] ``` More information: oven-sh/bun#8683
jamonholmgren
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Good to go. I added a comment linking to the Bun issue. @mazenchami
|
thanks! |
Johannes-Andersen
added a commit
to Johannes-Andersen/nsfwjs
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recommended by the Buffer maintainer:
This solves a bug found bundling NSFWJS with Bun.
More information: oven-sh/bun#8683