Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes storybook from codebase entirely, including storybook switch feature #1545

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jamonholmgren
Copy link
Member

This is a rather large PR, but the actual changes are fairly limited in surface area. It's part of my new effort to streamline and simplify Reactotron's code base to make it easier to work on.

  1. Removed Storybook on/off feature, as it's a confusing feature to set up, of minimal value, and we don't use Storybook anymore anyway
  2. Removed Storybook entirely from the dev code base too
  3. Fixed a bunch of dependency issues
  4. Fixed a bunch of lint / formatting errors

To review, mostly just look at the Storybook commit, unless you like looking at linting changes.

  • yarn build-and-test:local passes
  • README.md (or relevant documentation) has been updated with your changes
  • Tested manually, works

Copy link
Contributor

@frankcalise frankcalise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it spring already? 🧹

Generally looks fine to me, spotted one yarn config change that I'm unsure what it does

Copy link
Contributor

@silasjmatson silasjmatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for separating the lint/formatting fixes into their own commit. It made this much more reviewable. :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants