🐛 TypeScript Fixtravaganza #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmevans9
approved these changes
Sep 7, 2018
joshuayoes
pushed a commit
that referenced
this pull request
Feb 1, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
silasjmatson
pushed a commit
that referenced
this pull request
Mar 14, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few issues fixed here in the
typescripttheme...GraphQL
When i brought in apollo, it upped the graphql version to 14. This was incompatible with
graphqland@types/graphql13 which was being used bytype-graphql.Fortunately, @rmevans9 is a wizard and showed me how to fix via
yarn resolutions. There's currently an yarn issue that requires me to put theresolutionsin bothpackage.jsonandpackages/reactotron-server/package.json, but no big deal.tslint
I brought in
ts-lintforreactotron-server.typescript
I bumped the version to
3.0.3cuz there's some footguns in prior versions.tsconfig out dir changes
When you
tsca folder that has 2 directories, both directories are copied to theoutDir. 1 directory will only copy the contents (strangely enough). So I updated theoutDirto reflect that.Sorry about that. That caught me off guard.
.gitignore
I promoted the
.cacheto the root.gitignore. This is forparcel, but having 1.gitignoreis preferable sincevscodedoesn't seem to support unioning them together nicely (to make the folders dim in the explorer view).