Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds all-contributors-cli to the project #119

Merged
merged 6 commits into from
Nov 9, 2017

Conversation

mattathompson
Copy link
Contributor

@mattathompson mattathompson commented Nov 5, 2017

All Contributors - #114

  • Creates a new markdown file that is registered in the /.all-contributorsrc file.

@codecov
Copy link

codecov bot commented Nov 5, 2017

Codecov Report

Merging #119 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   75.86%   75.86%           
=======================================
  Files          21       21           
  Lines         377      377           
  Branches       67       67           
=======================================
  Hits          286      286           
  Misses         65       65           
  Partials       26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0b68cb...177bb71. Read the comment docs.

"projectOwner": "infinitered",
"files": [
"docs/existingContributors.md",
"README.md"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for updating the badge. But, the badge will need to be moved and updated to the HTML that all other badges are in.

That being said it looks like the all-contributors-cli supports updating the HTML formatted badge w/ the new count.

README.md Outdated
<img src="https://ci.appveyor.com/api/projects/status/eqn3imsv7pk75sjv/branch/master?svg=true">
</a>

<a href="https://infinitered.github.io/solidarity/#/docs/existingContributors">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is in html format the count won't be auto updated by the cli. Thinking about making a PR/fix for that project to work w/ both markup and html.

Otherwise we could write our own script.

…an't be automatically updated by the all-contributers-cli.
@mattathompson
Copy link
Contributor Author

@GantMan let me know if you have any more thoughts on this. You could also pull this down and add contributors and see what it looks like.

@GantMan
Copy link
Member

GantMan commented Nov 8, 2017

Ah, I was waiting for you to alert me when it was done. :) Otherwise I'm like a kid in a candy store watching you work. I'll review tonight.

@mattathompson
Copy link
Contributor Author

Word! My only question is about wether or not you want to have the badge that has the count of contributors in the README.md. We'd have to roll our own script to update it.

@GantMan
Copy link
Member

GantMan commented Nov 8, 2017

nah. We've gone so badge crazy, I think we can skip that one. Github has it properly noted.

@mattathompson
Copy link
Contributor Author

mattathompson commented Nov 8, 2017 via email

@GantMan
Copy link
Member

GantMan commented Nov 8, 2017

@mattathompson
Copy link
Contributor Author

mattathompson commented Nov 8, 2017

That's where the contributors list goes. Wasn't sure if you wanted to maintain this list yourself or not. Otherwise, I can go through and start adding contributors in this PR based off of who has contributed so far.

Basically, we just need to start running all-contributors add [GH Username] code,doc and it will append the new contributor to https://github.com/mattathompson/solidarity/blob/all-contributors/docs/existingContributors.md

@GantMan
Copy link
Member

GantMan commented Nov 8, 2017

O crap... there's no automated way? That's a pain! Maybe I should write a CLI for @jfmengels so it would automatically parse the git history, and identify suggested emojii for that person.

@GantMan
Copy link
Member

GantMan commented Nov 8, 2017

all-contributors/cli#49

@mattathompson
Copy link
Contributor Author

mattathompson commented Nov 8, 2017 via email

@GantMan
Copy link
Member

GantMan commented Nov 9, 2017

Looks good Matt. Not sure when I'd be able to make it automated, but that's on my list of open source TODO

@GantMan GantMan merged commit 114cd6a into infinitered:master Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants