-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds all-contributors-cli to the project #119
Conversation
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
=======================================
Coverage 75.86% 75.86%
=======================================
Files 21 21
Lines 377 377
Branches 67 67
=======================================
Hits 286 286
Misses 65 65
Partials 26 26 Continue to review full report at Codecov.
|
.all-contributorsrc
Outdated
"projectOwner": "infinitered", | ||
"files": [ | ||
"docs/existingContributors.md", | ||
"README.md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only for updating the badge. But, the badge will need to be moved and updated to the HTML that all other badges are in.
That being said it looks like the all-contributors-cli
supports updating the HTML formatted badge w/ the new count.
README.md
Outdated
<img src="https://ci.appveyor.com/api/projects/status/eqn3imsv7pk75sjv/branch/master?svg=true"> | ||
</a> | ||
|
||
<a href="https://infinitered.github.io/solidarity/#/docs/existingContributors"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this is in html format the count won't be auto updated by the cli. Thinking about making a PR/fix for that project to work w/ both markup and html.
Otherwise we could write our own script.
…an't be automatically updated by the all-contributers-cli.
@GantMan let me know if you have any more thoughts on this. You could also pull this down and add contributors and see what it looks like. |
Ah, I was waiting for you to alert me when it was done. :) Otherwise I'm like a kid in a candy store watching you work. I'll review tonight. |
Word! My only question is about wether or not you want to have the badge that has the count of contributors in the README.md. We'd have to roll our own script to update it. |
nah. We've gone so badge crazy, I think we can skip that one. Github has it properly noted. |
I agree.
…On Nov 7, 2017 8:46 PM, "Gant Laborde" ***@***.***> wrote:
nah. We've gone so badge crazy, I think we can skip that one. Github has
it properly noted.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#119 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF83K7D6YqNVWuS09qQih0VLMPD_Odbkks5s0QfxgaJpZM4QSZHh>
.
|
So actually, I'm confused. Should I see anything here? |
That's where the contributors list goes. Wasn't sure if you wanted to maintain this list yourself or not. Otherwise, I can go through and start adding contributors in this PR based off of who has contributed so far. Basically, we just need to start running |
O crap... there's no automated way? That's a pain! Maybe I should write a CLI for @jfmengels so it would automatically parse the git history, and identify suggested emojii for that person. |
That would be legit.
…On Nov 8, 2017 11:57 AM, "Gant Laborde" ***@***.***> wrote:
O crap... there's no automated way? That's a pain! Maybe I should write a
CLI for @jfmengels <https://github.com/jfmengels> so it would
automatically parse the git history, and identify suggested emojii for that
person.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#119 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF83K__iZG2EzLB6GsVyPeg0x89HDMTnks5s0d2GgaJpZM4QSZHh>
.
|
Looks good Matt. Not sure when I'd be able to make it automated, but that's on my list of open source TODO |
All Contributors - #114
/.all-contributorsrc
file.