AsyncIterator Support #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simlay
commented
Jan 14, 2021
simlay
commented
Jan 14, 2021
simlay
commented
Jan 14, 2021
simlay
commented
Jan 14, 2021
simlay
force-pushed
the
iterator-example
branch
3 times, most recently
from
10c4cd1 to
3b01d38
Compare
sehz
requested changes
Jan 19, 2021
simlay
force-pushed
the
iterator-example
branch
3 times, most recently
from
64754c2 to
b51f78e
Compare
src/fluvio.test.ts
Outdated
|
|
||
| const offsetIndex = 0 | ||
| const consumer = await fluvio.partitionConsumer(topic, partition) | ||
| const stream = await consumer.getIterator(Offset.FromBeginning()) |
There was a problem hiding this comment.
I think we should make this consistent with the Rust API and say consumer.stream(Offset) instead of calling it getIterator
There was a problem hiding this comment.
Yeah... the chat bot code depends on the closure version of stream. I agree though.
simlay
force-pushed
the
iterator-example
branch
from
b51f78e to
2116ba2
Compare
simlay
force-pushed
the
iterator-example
branch
from
2116ba2 to
e7a8a2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #66. This has some work around for some missing features in node-bindgen.