Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluvio cluster delete should delete helm chart #2032

Closed
tjtelan opened this issue Dec 21, 2021 · 0 comments
Closed

fluvio cluster delete should delete helm chart #2032

tjtelan opened this issue Dec 21, 2021 · 0 comments
Assignees
Labels
Milestone

Comments

@tjtelan
Copy link
Contributor

tjtelan commented Dec 21, 2021

This is a little extra cleanup that is currently left behind

Mostly developers will run into this problem, but it is still a source of confusion if there are changes related to the helm chart that change during development (within the same version).


You should be able to validate by running helm ls and fluvio and fluvio-sys should not be listed.

Manual repro:

Start a cluster

$ fluvio cluster start
     📝 Running pre-flight checks
     ✅ Kubernetes config is loadable
     ✅ Supported helm version is installed
     ✅ Fluvio system charts are installed
     ✅ Previous fluvio installation not found
🛠️  Installing Fluvio
     ✅ Fluvio app chart has been installed
🔎 Found SC service addr: 172.18.0.2:30003
👤 Profile set
🤖 SPU group launched (1)
     ✅ All SPUs confirmed
🎯 Successfully installed Fluvio!

List all the installed charts

$ helm ls
NAME            NAMESPACE       REVISION        UPDATED                                        STATUS        CHART            APP VERSION
fluvio          default         1               2021-12-21 15:37:27.030380933 -0800 PST        deployed      fluvio-app-0.9.2 0.9.15     
fluvio-sys      default         11              2021-12-15 18:09:28.457210598 -0800 PST        deployed      fluvio-sys-0.9.6 0.9.16     

Then we delete the cluster

$ fluvio cluster delete

The fluvio-sys chart is still here

$ helm ls
NAME            NAMESPACE       REVISION        UPDATED                                      STATUS          CHART                   APP VERSION
fluvio-sys      default         11              2021-12-15 18:09:28.457210598 -0800 PST      deployed        fluvio-sys-0.9.6        0.9.16
@tjtelan tjtelan added enhancement New feature or request good first issue Good for newcomers labels Dec 21, 2021
@sehz sehz added this to the 0.9.16 milestone Dec 22, 2021
@sehz sehz added Installation k8/helm and removed good first issue Good for newcomers labels Dec 22, 2021
@bors bors bot closed this as completed in c282b96 Dec 23, 2021
bors bot pushed a commit that referenced this issue Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants