Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech debt: Testing Fluvio Socket Multiplexor #3174

Open
sehz opened this issue Apr 19, 2023 · 3 comments
Open

tech debt: Testing Fluvio Socket Multiplexor #3174

sehz opened this issue Apr 19, 2023 · 3 comments
Labels
help wanted Good issue for community involvement network technical debt

Comments

@sehz
Copy link
Contributor

sehz commented Apr 19, 2023

Socket Multiplexor is quite complex with lots of different path and error condition. Existing integration test only cover a simple happy path. Need additional testing to cover different path. Maybe fuzzing testing?

@sehz sehz added help wanted Good issue for community involvement technical debt network advanced labels Apr 19, 2023
@sehz sehz removed the advanced label May 6, 2023
@TanNgocDo
Copy link
Contributor

There are several scenarios, to name a few:
Integration test:

  1. Client have multiple multiplexer from one socket but one multiplexer is close(literal use:multiplexor_clone.terminate.notify(usize::MAX)); => should have some test case error handling for other multiplexers
  2. Server dies after sometimes, client needs to have some test to handle.
    ......
    With fuzz test: maybe generating a variable of input msg for EchoRequest and AsyncRequest...

Just my 2-cent thinking, should be more scenarios
Thanks

@TanNgocDo
Copy link
Contributor

@sehz , I have just 2 more naive test for multiplexing(not including fuzz yet)
Welcome for suggestions on more scenarios + refactoring code.
Thanks

@sehz
Copy link
Contributor Author

sehz commented May 13, 2023

Thanks. Will have someone look at that

bors bot pushed a commit that referenced this issue May 16, 2023
This is an attempt to add more integration test for #3174 . 
Need to be update more case + fuzz test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Good issue for community involvement network technical debt
Projects
None yet
Development

No branches or pull requests

2 participants