Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - add more multiplexing_test #3249

Closed

Conversation

TanNgocDo
Copy link
Contributor

This is an attempt to add more integration test for #3174 .
Need to be update more case + fuzz test

@sehz
Copy link
Contributor

sehz commented May 13, 2023

clippy failures

@sehz sehz requested review from galibey, digikata and morenol and removed request for digikata May 13, 2023 03:59
@sehz
Copy link
Contributor

sehz commented May 13, 2023

@galibey @morenol Please review

fix clippy issue
fix format issue
crates/fluvio-socket/src/multiplexing.rs Outdated Show resolved Hide resolved
crates/fluvio-socket/src/multiplexing.rs Outdated Show resolved Hide resolved
@galibey
Copy link
Contributor

galibey commented May 16, 2023

Need to increment patch version here

version = "0.14.2"
to make CI happy.

Probably, need to rebase from master as well.

@TanNgocDo
Copy link
Contributor Author

version = "0.14.2"

@galibey , should it be: "0.14.3", right ?

@galibey
Copy link
Contributor

galibey commented May 16, 2023

version = "0.14.2"

@galibey , should it be: "0.14.3", right ?

yes

Copy link
Contributor

@galibey galibey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galibey
Copy link
Contributor

galibey commented May 16, 2023

bors r+

bors bot pushed a commit that referenced this pull request May 16, 2023
This is an attempt to add more integration test for #3174 . 
Need to be update more case + fuzz test
@bors
Copy link

bors bot commented May 16, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title add more multiplexing_test [Merged by Bors] - add more multiplexing_test May 16, 2023
@bors bors bot closed this May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants