feat(hub): enable repository_url
#3961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EstebanBorai
force-pushed
the
feat/hub-package-meta-fields
branch
from
5f97f4a
to
5663c81
Compare
digikata
reviewed
Apr 22, 2024
| pub description: String, | ||
| pub license: String, | ||
| pub manifest: Vec<String>, // Files in package, package-meta is implied, signature is omitted | ||
| pub repository_url: Option<Url>, | ||
| pub repository_commit_sha: Option<String>, |
There was a problem hiding this comment.
Lets leave out repository_commit_sha for now. We can re-introduce it later as a tag if needed.
There was a problem hiding this comment.
SGTM! Here is the change: 9babcd7
digikata
approved these changes
Apr 22, 2024
EstebanBorai
changed the title
repository_url and repository_commit_sharepository_url
fraidev
pushed a commit
to fraidev/fluvio
that referenced
this pull request
Apr 23, 2024
* feat(hub): enable `repository_url` and `repository_commit_sha` * fix: fmt issues * fix: rm commit sha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.