Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hub): enable repository_url #3961

Merged
merged 4 commits into from
Apr 23, 2024
Merged

feat(hub): enable repository_url #3961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5663c81
feat(hub): enable `repository_url` and `repository_commit_sha`
EstebanBorai Apr 22, 2024
58e3ac7
fix: fmt issues
EstebanBorai Apr 22, 2024
9babcd7
fix: rm commit sha
EstebanBorai Apr 22, 2024
ea15ac3
Merge branch 'master' into feat/hub-package-meta-fields
EstebanBorai Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion crates/fluvio-hub-protocol/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,13 @@ publish = false
cargo_toml = { workspace = true }
const_format = { workspace = true }
dirs = { workspace = true }
serde = { workspace = true, features=["derive"] }
serde = { workspace = true, features = ["derive"] }
serde_json = { workspace = true }
serde_yaml = { workspace = true }
toml = { workspace = true }
tracing = { workspace = true }
thiserror = { workspace = true }
url = { workspace = true, features = ["serde"] }

fluvio-controlplane-metadata = { workspace = true, features = [ "smartmodule" ] }
fluvio-types = { workspace = true }
10 changes: 5 additions & 5 deletions crates/fluvio-hub-protocol/src/package_meta.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ use std::default::Default;

use serde::{Deserialize, Serialize};
use tracing::{info, error};
use url::Url;

use fluvio_controlplane_metadata::smartmodule::FluvioSemVersion;
use fluvio_controlplane_metadata::smartmodule::SmartModulePackageKey;
Expand All @@ -18,16 +19,14 @@ pub struct PackageMeta {
pub name: String,
pub version: String, // SemVer?, package version
pub group: String,
// author: Option<String>,
pub description: String,
pub license: String,
pub manifest: Vec<String>, // Files in package, package-meta is implied, signature is omitted
pub repository_url: Option<Url>,
pub tags: Option<Vec<PkgTag>>,

#[serde(default = "PackageMeta::visibility_if_missing")]
pub visibility: PkgVisibility, // private is default if missing
pub manifest: Vec<String>, // Files in package, package-meta is implied, signature is omitted
// repository: optional url
// repository-commit: optional hash
pub tags: Option<Vec<PkgTag>>,
}

#[derive(Serialize, Deserialize, PartialEq, Eq, Debug, Default, Clone)]
Expand Down Expand Up @@ -56,6 +55,7 @@ impl Default for PackageMeta {
visibility: PkgVisibility::Private,
manifest: Vec::new(),
tags: None,
repository_url: None,
}
}
}
Expand Down
Loading