[Merged by Bors] - migrated FluvioSocket to use trait object #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehz
changed the title
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 1, 2021
Migrate FluvioSocket to use TraitObject (BoxConnection) instead of using generic signatures. This allow Fluvio client to use any TCP connection as long as they satisfy: `AsyncRead + AsyncWrite`. Also rename remove `Flv` as full `Fulvio(FluvioSocket,FluvioSink,FluvioStream)` No changed in any business logic. This is purely changing type signature to make it easier to plug-in different Tcp connection types. Because of type API change, all crates's major version have been updated
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate FluvioSocket to use TraitObject (BoxConnection) instead of using generic signatures.
This allow Fluvio client to use any TCP connection as long as they satisfy:
AsyncRead + AsyncWrite.Also rename remove
Flvas fullFulvio(FluvioSocket,FluvioSink,FluvioStream)No changed in any business logic. This is purely changing type signature to make it easier to plug-in different Tcp connection types.
Because of type API change, all crates's major version have been updated