[Merged by Bors] - Give user feedback when consuming in interactive mode #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholastmosher
force-pushed
the
consumer-feedback
branch
from
a96b0d4
to
0b6b7c2
Compare
|
conflict |
nicholastmosher
force-pushed
the
consumer-feedback
branch
from
0b6b7c2
to
fb667c7
Compare
|
@sehz should be ready now |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 27, 2021
Closes #700 When using the Consumer CLI in "interactive mode", the CLI will now print a little message about how it is going to consume. <img width="669" alt="image" src="https://user-images.githubusercontent.com/4210949/122231966-e0f5a080-ce88-11eb-8073-d11d3ca12848.png"> The most important one here is in the case that no flags are given, e.g. `fluvio consume one`. This was confusing to the user in the past because it would appear to just hang as if it were loading, when it was actually consuming from the end of the partition and just waiting for records to arrive. Now there's a message to say that.
|
Build failed: |
|
This seems to be spurious CI failure, going to try again
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 28, 2021
Closes #700 When using the Consumer CLI in "interactive mode", the CLI will now print a little message about how it is going to consume. <img width="669" alt="image" src="https://user-images.githubusercontent.com/4210949/122231966-e0f5a080-ce88-11eb-8073-d11d3ca12848.png"> The most important one here is in the case that no flags are given, e.g. `fluvio consume one`. This was confusing to the user in the past because it would appear to just hang as if it were loading, when it was actually consuming from the end of the partition and just waiting for records to arrive. Now there's a message to say that.
|
Build failed: |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 28, 2021
Closes #700 When using the Consumer CLI in "interactive mode", the CLI will now print a little message about how it is going to consume. <img width="669" alt="image" src="https://user-images.githubusercontent.com/4210949/122231966-e0f5a080-ce88-11eb-8073-d11d3ca12848.png"> The most important one here is in the case that no flags are given, e.g. `fluvio consume one`. This was confusing to the user in the past because it would appear to just hang as if it were loading, when it was actually consuming from the end of the partition and just waiting for records to arrive. Now there's a message to say that.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #700
When using the Consumer CLI in "interactive mode", the CLI will now print a little message about how it is going to consume.
The most important one here is in the case that no flags are given, e.g.
fluvio consume one. This was confusing to the user in the past because it would appear to just hang as if it were loading, when it was actually consuming from the end of the partition and just waiting for records to arrive. Now there's a message to say that.