Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add exe suffic for windows targets #1461

Closed
wants to merge 1 commit into from

Conversation

simlay
Copy link
Contributor

@simlay simlay commented Aug 19, 2021

Closes #1369.
Closes #1372.

Copy link
Contributor

@nicholastmosher nicholastmosher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but I don't have a windows machine to test it. If you've tested it and everything works, I'm good with it 👍

@simlay
Copy link
Contributor Author

simlay commented Aug 19, 2021

bors r+

bors bot pushed a commit that referenced this pull request Aug 19, 2021
@bors
Copy link

bors bot commented Aug 19, 2021

Build failed:

@simlay
Copy link
Contributor Author

simlay commented Aug 19, 2021

bors retry

bors bot pushed a commit that referenced this pull request Aug 19, 2021
@bors
Copy link

bors bot commented Aug 19, 2021

Build failed:

@simlay
Copy link
Contributor Author

simlay commented Aug 19, 2021

bors retry

bors bot pushed a commit that referenced this pull request Aug 19, 2021
@bors
Copy link

bors bot commented Aug 19, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Add exe suffic for windows targets [Merged by Bors] - Add exe suffic for windows targets Aug 19, 2021
@bors bors bot closed this Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update fluvio install to work properly on Windows Windows client support
2 participants