Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fast records logs validation #1726

Closed
wants to merge 33 commits into from

Conversation

sehz
Copy link
Contributor

@sehz sehz commented Oct 5, 2021

resolves #1704.

  • Reduced validation time for 1G log (max size) from 86 seconds to ~230ms by using memory mapped file rather than standard file I/O
  • Updated storage unit-tests to make it more robust and not hard code file name

@sehz sehz marked this pull request as draft October 5, 2021 15:44
@sehz sehz changed the title Memap fast lookup fast records logs validation Oct 5, 2021
@sehz sehz marked this pull request as ready for review October 5, 2021 21:55
@sehz
Copy link
Contributor Author

sehz commented Oct 5, 2021

bors r+

bors bot pushed a commit that referenced this pull request Oct 5, 2021
resolves #1704.

* Reduced validation time for 1G log (max size) from 86 seconds to ~230ms by using memory mapped file rather than standard file I/O
* Updated storage unit-tests to make it more robust and not hard code file name
@bors
Copy link

bors bot commented Oct 5, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fast records logs validation [Merged by Bors] - fast records logs validation Oct 5, 2021
@bors bors bot closed this Oct 5, 2021
@sehz sehz deleted the memap_fast_lookup branch February 16, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slow segment validation when loading existing segment
1 participant