Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minikube storage and fix ci_mac #1958

Closed
wants to merge 10 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/ci_mac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ permissions:
contents: read

concurrency:
group: ${{ 'ci_tier2' }}
group: ${{ github.head_ref || 'ci_mac_staging' }}
cancel-in-progress: true

on:
Expand Down Expand Up @@ -284,6 +284,7 @@ jobs:
uses: docker-practice/actions-setup-docker@master
# Retag image to remove arch from tag
- name: Load Fluvio Docker Image for K3d
if: ${{ false }}
run: |
ls -la /tmp
docker image load --input /tmp/infinyon-fluvio-${{ matrix.k8-target }}.tar
Expand All @@ -294,18 +295,19 @@ jobs:
if: ${{ matrix.k8 == 'kind' }}
run: |
brew install kind
kind create cluster --config k8-util/cluster/kind.yaml
kind version
kind create cluster --config k8-util/cluster/kind.yaml
- name: Load image to kind
if: ${{ matrix.k8 == 'kind' }}
run: |
kind load docker-image infinyon/fluvio:${{ github.sha }}
- name: Run smoke-test-k8-tls-root
kind load image-archive /tmp/infinyon-fluvio-${{ matrix.k8-target }}.tar --name fluvio
- name: Run smoke-test-k8
timeout-minutes: 10
env:
FLV_DISPATCHER_WAIT: 300 # k3d in Github make take while to provision PVC
run: |
date
make FLUVIO_BIN=./fluvio TEST_BIN=./fluvio-test EXTRA_ARG="--cluster-start --proxy-addr 127.0.0.1" UNINSTALL=noclean smoke-test-k8-tls
make FLUVIO_BIN=./fluvio TEST_BIN=./fluvio-test EXTRA_ARG="--cluster-start --proxy-addr 127.0.0.1" UNINSTALL=noclean smoke-test-k8
- name: Print version
run: |
./fluvio version
Expand Down
5 changes: 3 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -327,10 +327,11 @@ upgrade: build-cli build_k8_image
$(FLUVIO_BIN) cluster upgrade --sys
$(FLUVIO_BIN) cluster upgrade --rust-log $(SERVER_LOG) --develop

clean_charts:
make -C k8-util/helm clean

clean:
clean: clean_charts
cargo clean
make -C k8-util/helm clean


.EXPORT_ALL_VARIABLES:
Expand Down
2 changes: 1 addition & 1 deletion k8-util/cluster/cluster-type.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ if echo ${nodes} | grep -q minikube; then
echo 'minikube'
elif echo ${nodes} | grep -q k3d; then
echo "k3d"
elif echo ${nodes} | grep -q kind; then
elif echo ${nodes} | grep -q control-plane; then
echo "kind"
elif echo ${nodes} | grep -q microk8s; then
echo "microk8"
Expand Down
3 changes: 2 additions & 1 deletion k8-util/docker/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ main() {

if [ "$K8" = "kind" ]; then
echo "export image to kind cluster"
kind load docker-image $docker_repo:$commit_hash
docker image save "$docker_repo:$commit_hash" --output /tmp/infinyon-fluvio.tar
kind load image-archive /tmp/infinyon-fluvio.tar --name fluvio
fi

if [ "$K8" = "microk8" ]; then
Expand Down
2 changes: 1 addition & 1 deletion k8-util/helm/fluvio-sys/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ apiVersion: v2
name: fluvio-sys
description: A Helm chart for Fluvio
type: application
version: 0.9.4
version: 0.9.5
7 changes: 0 additions & 7 deletions k8-util/helm/fluvio-sys/templates/minikube-storage.yaml

This file was deleted.