Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(connector): update #2188

Closed
wants to merge 8 commits into from

Conversation

pinkforest
Copy link
Contributor

@pinkforest pinkforest commented Feb 11, 2022

Closing #2154 (see caveats)

Adds fluvio connector update -c config_file

@wendyOn wendyOn linked an issue Feb 11, 2022 that may be closed by this pull request
@pinkforest pinkforest changed the title [WIP] feat(connector): update - initial draft boiler feat(connector): update - initial draft boiler Feb 15, 2022
@pinkforest pinkforest changed the title feat(connector): update - initial draft boiler feat(connector): update Feb 15, 2022
@wendyOn wendyOn requested a review from simlay February 15, 2022 12:01
@wendyOn wendyOn requested review from morenol and removed request for simlay February 15, 2022 12:15
Copy link
Contributor

@morenol morenol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some small nits

crates/fluvio-cli/src/connector/update.rs Outdated Show resolved Hide resolved
crates/fluvio-cli/src/connector/update.rs Outdated Show resolved Hide resolved
crates/fluvio-cli/src/connector/update.rs Outdated Show resolved Hide resolved
crates/fluvio-cli/src/connector/update.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@simlay simlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Feb 15, 2022
Closing #2154 (see caveats)

Adds fluvio connector update -c config_file
@morenol
Copy link
Contributor

morenol commented Feb 15, 2022

bors r-

I just added a new comment because I think that there is a typo

@bors
Copy link

bors bot commented Feb 15, 2022

Canceled.

@morenol
Copy link
Contributor

morenol commented Feb 15, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 15, 2022
Closing #2154 (see caveats)

Adds fluvio connector update -c config_file
@bors
Copy link

bors bot commented Feb 15, 2022

Canceled.

@morenol
Copy link
Contributor

morenol commented Feb 15, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 15, 2022
Closing #2154 (see caveats)

Adds fluvio connector update -c config_file

Co-authored-by: Luis Moreno <22335041+morenol@users.noreply.github.com>
@bors
Copy link

bors bot commented Feb 15, 2022

Canceled.

@morenol
Copy link
Contributor

morenol commented Feb 15, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 15, 2022
Closing #2154 (see caveats)

Adds fluvio connector update -c config_file

Co-authored-by: Luis Moreno <22335041+morenol@users.noreply.github.com>
Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
@bors
Copy link

bors bot commented Feb 15, 2022

Canceled.

@morenol
Copy link
Contributor

morenol commented Feb 15, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 15, 2022
Closing #2154 (see caveats)

Adds fluvio connector update -c config_file

Co-authored-by: Luis Moreno <22335041+morenol@users.noreply.github.com>
Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
@morenol
Copy link
Contributor

morenol commented Feb 15, 2022

bors r-

@bors
Copy link

bors bot commented Feb 15, 2022

Canceled.

@morenol
Copy link
Contributor

morenol commented Feb 15, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 15, 2022
Closing #2154 (see caveats)

Adds fluvio connector update -c config_file
@pinkforest pinkforest mentioned this pull request Feb 15, 2022
@bors
Copy link

bors bot commented Feb 15, 2022

Build failed:

@morenol
Copy link
Contributor

morenol commented Feb 15, 2022

bors retry

bors bot pushed a commit that referenced this pull request Feb 15, 2022
Closing #2154 (see caveats)

Adds fluvio connector update -c config_file
@bors
Copy link

bors bot commented Feb 15, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(connector): update [Merged by Bors] - feat(connector): update Feb 15, 2022
@bors bors bot closed this Feb 15, 2022
@wendyOn wendyOn self-assigned this Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connector: Update config command
5 participants