Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Rework/optimize partition size computation #2243

Conversation

Afourcat
Copy link
Contributor

This PR Implements #2230.

  • Add smoke-test
  • Bumps fluvio-future to 0.3.15.
  • Replace File-based computation of logs' length by the sum of active and previous Segments msg_log size.
    Which removes the need for file system IO.
  • Change tests

Copy link
Contributor Author

@Afourcat Afourcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't bump the fluvio-storage version since all changes seem to be internal.
Should I bump it anyway?

crates/fluvio-storage/src/replica.rs Show resolved Hide resolved
crates/fluvio-storage/src/replica.rs Show resolved Hide resolved
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Couple of minor nits. Can you also add to changelog?

Thanks!

crates/fluvio-storage/src/replica.rs Outdated Show resolved Hide resolved
crates/fluvio-storage/src/replica.rs Show resolved Hide resolved
crates/fluvio-storage/src/replica.rs Outdated Show resolved Hide resolved
crates/fluvio-storage/src/replica.rs Show resolved Hide resolved
@Afourcat Afourcat requested a review from sehz March 11, 2022 12:10
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work!

@sehz
Copy link
Contributor

sehz commented Mar 11, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 11, 2022
This PR Implements #2230.

- Add smoke-test
- Bumps `fluvio-future` to `0.3.15`.
- Replace File-based computation of logs' length by the sum of active and previous `Segment`s `msg_log` size.
Which removes the need for file system IO.
- Change tests
@bors
Copy link

bors bot commented Mar 11, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Rework/optimize partition size computation [Merged by Bors] - Rework/optimize partition size computation Mar 11, 2022
@bors bors bot closed this Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants