-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Rework/optimize partition size computation #2243
[Merged by Bors] - Rework/optimize partition size computation #2243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't bump the fluvio-storage
version since all changes seem to be internal.
Should I bump it anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Couple of minor nits. Can you also add to changelog?
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work!
bors r+ |
This PR Implements #2230. - Add smoke-test - Bumps `fluvio-future` to `0.3.15`. - Replace File-based computation of logs' length by the sum of active and previous `Segment`s `msg_log` size. Which removes the need for file system IO. - Change tests
Pull request successfully merged into master. Build succeeded: |
This PR Implements #2230.
fluvio-future
to0.3.15
.Segment
smsg_log
size.Which removes the need for file system IO.