[Merged by Bors] - Move stream publishers to connection-level context #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
This is the first PR of implementation of dropping a stream's server-side counterpart when a stream on the client-side is dropped. This is all part of the activities for managing offsets per consumer on the SPU side. Currently, the lifetime of `StreamPublisher` is equal to the lifetime of Tcp connection between SPU and client. We do not clean up `StreamPublishers` until the connection is dropped. Therefore, there is no need to keep them inside `GlobalContext` and have it multi-threaded, because it is always touched by only one thread (the one that handles connection). This PR doesn't add or remove any functional behavior. The `StreamPublishers` will be dropped after disconnect as it does now. The actual drop mechanism will go in another PR.
|
Build failed: |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
This is the first PR of implementation of dropping a stream's server-side counterpart when a stream on the client-side is dropped. This is all part of the activities for managing offsets per consumer on the SPU side. Currently, the lifetime of `StreamPublisher` is equal to the lifetime of Tcp connection between SPU and client. We do not clean up `StreamPublishers` until the connection is dropped. Therefore, there is no need to keep them inside `GlobalContext` and have it multi-threaded, because it is always touched by only one thread (the one that handles connection). This PR doesn't add or remove any functional behavior. The `StreamPublishers` will be dropped after disconnect as it does now. The actual drop mechanism will go in another PR.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR of implementation of dropping a stream's server-side counterpart when a stream on the client-side is dropped. This is all part of the activities for managing offsets per consumer on the SPU side.
Currently, the lifetime of
StreamPublisheris equal to the lifetime of Tcp connection between SPU and client. We do not clean upStreamPublishersuntil the connection is dropped. Therefore, there is no need to keep them insideGlobalContextand have it multi-threaded, because it is always touched by only one thread (the one that handles connection).This PR doesn't add or remove any functional behavior. The
StreamPublisherswill be dropped after disconnect as it does now. The actual drop mechanism will go in another PR.