[Merged by Bors] - Do not allow --initial when we are not using aggregate smartmodule #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 13, 2022
…2476) I noticed that in `fluvio consume` we can use `--initial` and `--join-topic` when we are not using their respective smart modules. This fixes that, now if we use `--initial` without using --aggregate or --smartmodule the CLI will fail with the right description. The same applies to `--extra-params`
|
Build failed: |
|
Yuck: |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 13, 2022
…2476) I noticed that in `fluvio consume` we can use `--initial` and `--join-topic` when we are not using their respective smart modules. This fixes that, now if we use `--initial` without using --aggregate or --smartmodule the CLI will fail with the right description. The same applies to `--extra-params`
|
Build failed: |
morenol
force-pushed
the
lmm/cli-enforce-parameters
branch
from
796b99a
to
6de187d
Compare
morenol
force-pushed
the
lmm/cli-enforce-parameters
branch
from
6de187d
to
45b0044
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
…2476) I noticed that in `fluvio consume` we can use `--initial` and `--join-topic` when we are not using their respective smart modules. This fixes that, now if we use `--initial` without using --aggregate or --smartmodule the CLI will fail with the right description. The same applies to `--extra-params`
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in
fluvio consumewe can use--initialand--join-topicwhen we are not using their respective smart modules. This fixes that, now if we use--initialwithout using --aggregate or --smartmodule the CLI will fail with the right description.The same applies to
--extra-params