Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add AtMostOnce and AtLeastOnce delivery semantics #2503

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Add AtMostOnce and AtLeastOnce delivery semantics #2503

wants to merge 2 commits into from

Conversation

galibey
Copy link
Contributor

@galibey galibey commented Jul 26, 2022

Added two delivery semantics to Producer:
1. AtMostOnce - we send records and do not wait for a response. To wait for the response, one could use ProduceOutput::wait after sending the record.
2. AtLeastOnce - we send records, wait for the response and retry if a network error occurs.

The default retry policy:
retries: 4,
max timeout: 300s
delays sequence: 20ms, 400ms, 8s, 160s (Exponential Backoff)

Related #2481

@galibey galibey requested review from sehz and morenol July 26, 2022 09:13
Copy link
Contributor

@morenol morenol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Looks good to me!

Copy link
Contributor

@tjtelan tjtelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

@sehz sehz added this to the 0.9.32 milestone Jul 26, 2022
@sehz
Copy link
Contributor

sehz commented Jul 26, 2022

Can you link to existing issue?

@sehz
Copy link
Contributor

sehz commented Jul 26, 2022

bors r+

@sehz sehz linked an issue Jul 26, 2022 that may be closed by this pull request
bors bot pushed a commit that referenced this pull request Jul 26, 2022
Added two delivery semantics to Producer:
     1. `AtMostOnce` - we send records and do not wait for a response. To wait for the response, one could use ProduceOutput::wait after sending the record.     
     2. `AtLeastOnce` - we send records, wait for the response and retry if a network error occurs.     
     
The default retry policy:
retries: 4,
max timeout: 300s
delays sequence: 20ms, 400ms, 8s, 160s (Exponential Backoff)
@bors
Copy link

bors bot commented Jul 26, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Add AtMostOnce and AtLeastOnce delivery semantics [Merged by Bors] - Add AtMostOnce and AtLeastOnce delivery semantics Jul 26, 2022
@bors bors bot closed this Jul 26, 2022
@galibey galibey deleted the feature/2481-add-delivery-semantics-to-producer branch October 27, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for at least once and at most once in the Producer Client
4 participants