-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Add AtMostOnce
and AtLeastOnce
delivery semantics
#2503
[Merged by Bors] - Add AtMostOnce
and AtLeastOnce
delivery semantics
#2503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work!
Can you link to existing issue? |
bors r+ |
Added two delivery semantics to Producer: 1. `AtMostOnce` - we send records and do not wait for a response. To wait for the response, one could use ProduceOutput::wait after sending the record. 2. `AtLeastOnce` - we send records, wait for the response and retry if a network error occurs. The default retry policy: retries: 4, max timeout: 300s delays sequence: 20ms, 400ms, 8s, 160s (Exponential Backoff)
Pull request successfully merged into master. Build succeeded: |
AtMostOnce
and AtLeastOnce
delivery semanticsAtMostOnce
and AtLeastOnce
delivery semantics
Added two delivery semantics to Producer:
1.
AtMostOnce
- we send records and do not wait for a response. To wait for the response, one could use ProduceOutput::wait after sending the record.2.
AtLeastOnce
- we send records, wait for the response and retry if a network error occurs.The default retry policy:
retries: 4,
max timeout: 300s
delays sequence: 20ms, 400ms, 8s, 160s (Exponential Backoff)
Related #2481