Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: add instrumentation to client producer #2717

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat: add instrumentation to client producer #2717

wants to merge 4 commits into from

Conversation

nacardin
Copy link
Contributor

@nacardin nacardin commented Oct 18, 2022 •
edited by bors bot
Loading

No description provided.

sehz
sehz requested changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Few minor nits

crates/fluvio/Cargo.toml Outdated Show resolved Hide resolved
crates/fluvio/src/lib.rs Outdated Show resolved Hide resolved
crates/fluvio/src/producer/partition_producer.rs Outdated Show resolved Hide resolved
crates/fluvio/src/producer/partition_producer.rs Outdated Show resolved Hide resolved
galibey
galibey reviewed Oct 19, 2022
View reviewed changes
crates/fluvio/Cargo.toml Outdated Show resolved Hide resolved
galibey
galibey reviewed Oct 19, 2022
View reviewed changes
crates/fluvio/src/lib.rs Outdated Show resolved Hide resolved
tjtelan
tjtelan reviewed Oct 19, 2022
View reviewed changes
crates/fluvio/src/lib.rs Outdated Show resolved Hide resolved
@nacardin nacardin marked this pull request as ready for review October 19, 2022 20:17
@nacardin nacardin requested review from sehz and galibey October 19, 2022 20:17
sehz
sehz requested changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor issue

crates/fluvio/Cargo.toml Outdated Show resolved Hide resolved
@nacardin nacardin requested a review from sehz October 19, 2022 20:42
sehz
sehz approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nacardin
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 19, 2022
@nacardin
feat: add instrumentation to client producer (#2717)
e3195c8 
Co-authored-by: Nick Cardin <nick@cardin.email>
@bors
Copy link

bors bot commented Oct 19, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: add instrumentation to client producer [Merged by Bors] - feat: add instrumentation to client producer Oct 19, 2022
@bors bors bot closed this Oct 19, 2022
davidbeesley pushed a commit to davidbeesley/fluvio that referenced this pull request Oct 31, 2022
@nacardin @davidbeesley
feat: add instrumentation to client producer (infinyon#2717)
b4f7de4 
Co-authored-by: Nick Cardin <nick@cardin.email>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjtelan tjtelan tjtelan left review comments

@sehz sehz sehz approved these changes

@galibey galibey Awaiting requested review from galibey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nacardin @tjtelan @sehz @galibey