[Merged by Bors] - feat: benches with criterion and dedicated workflow

[EstebanBorai]

Replaces benchmarking with Criterion crate and provides a dedicated
workflow for running benchmarks as part of CI. As we add more benchmarks
to source code, the benchmarks workflow will grow with configuration for each
crate in the project.

[EstebanBorai]

@sehz , @morenol looks like we will have to provide special permissions for Benchmark workflow in order to allow commenting on commit:

Run benchmark-action/github-action-benchmark@v1
Error: Resource not accessible by integration

Actual Log

---

I believe this is related: https://stackoverflow.com/questions/70435286/resource-not-accessible-by-integration-on-github-post-repos-owner-repo-ac

[sehz]

CI failure

[EstebanBorai]

CI failure

Yeah, its related to permissions I left this comment here: #2770 (comment).

I see other people complaining about similar issue here: actions/first-interaction#10

[EstebanBorai]

Checking on the GitHub Token Permissions I can see we can only read PR:

GITHUB_TOKEN Permissions
  Metadata: read
  PullRequests: read

I think we could add an custom token for this workflow which allows write perhaps?

Actual Log

I also opened an issue on the action repository to ask for permissions scopes we could use for our workflow.

[morenol]

I guess that we could make it only run on master branch, I think that for pushes to that branch we won't get permission issues

[sehz]

maybe one way to solve permission issues is only cache the benchmark only master

[morenol]

bors r+

[morenol]

ohh, clippy issues!

[bors]

Build failed:

• Done

[EstebanBorai]

@morenol reviewing!

[EstebanBorai]

ohh, clippy issues!

Doesn't look related to this PR: https://github.com/infinyon/fluvio/actions/runs/3386673257/jobs/5626387694#step:8:1252
Will fix in a separate one, to also focus tests and checks on such change instead of introducing both things here.

[EstebanBorai]

ohh, clippy issues!

Doesn't look related to this PR: https://github.com/infinyon/fluvio/actions/runs/3386673257/jobs/5626387694#step:8:1252 Will fix in a separate one, to also focus tests and checks on such change instead of introducing both things here.

Just saw you took care of this already here: #2771 Great!

[morenol]

bors retry

[bors]

Pull request successfully merged into master.

Build succeeded:

• Done