[Merged by Bors] - Remove lazy_static in favor of once_cell #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheus-consoli
force-pushed
the
remove-lazy-static
branch
from
d1e91b8
to
865409a
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
`fluvio-package-index` was the only package using `lazy_static` - this small change favors `once_cell` instead. This way we have one less dependency and it will be easier to update once [`std::sync::LazyLock`](https://doc.rust-lang.org/std/sync/struct.LazyLock.html) is stabilized.
|
Build failed: |
|
Build failed on the crate version check - it detected a code change without a version change. Is it ok to ignore it and merge (since nothing meaningful changed), or is it preferable to bump a minor? |
|
All merges need to go thru bors (there is no exception). So in order to make bors happy, need to bump up minor version. Should create issue to skipped version check if changes are only related to tests |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
`fluvio-package-index` was the only package using `lazy_static` - this small change favors `once_cell` instead. This way we have one less dependency and it will be easier to update once [`std::sync::LazyLock`](https://doc.rust-lang.org/std/sync/struct.LazyLock.html) is stabilized.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fluvio-package-indexwas the only package usinglazy_static- this small change favorsonce_cellinstead.This way we have one less dependency and it will be easier to update once
std::sync::LazyLockis stabilized.