Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: add cascade deletion for local metadata #3638

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat: add cascade deletion for local metadata #3638

wants to merge 2 commits into from

Conversation

galibey
Copy link
Contributor

@galibey galibey commented Oct 31, 2023

Added cascade deletion for local metadata.

Also, fixed a bug with deserialization failure for nested enums if the outer enum is tagged. More details here dtolnay/serde-yaml#378. Fixed by removing external tagging for versioned spec and added unit-tests that cover this case.

Also fixes #3632

@galibey galibey changed the title Feat/add cascade deletion to local metadata feat: add cascade deletion for local metadata Oct 31, 2023
@galibey galibey self-assigned this Oct 31, 2023
@galibey galibey marked this pull request as ready for review October 31, 2023 08:32
@galibey galibey requested review from digikata and sehz October 31, 2023 08:32
crates/fluvio-stream-model/src/core.rs Outdated Show resolved Hide resolved
crates/fluvio-stream-model/src/core.rs Outdated Show resolved Hide resolved
crates/fluvio-stream-model/src/core.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice job.

Only possible problem I see is that some of tests in the CI were not running reliably with local mode with previous changes. So need to check if they are running ok once this is merged.

@galibey
Copy link
Contributor Author

galibey commented Nov 2, 2023

bors r+

bors bot pushed a commit that referenced this pull request Nov 2, 2023
Added cascade deletion for local metadata.

Also, fixed a bug with deserialization failure for nested enums if the outer enum is tagged. More details here dtolnay/serde-yaml#378. Fixed by removing external tagging for versioned spec and added unit-tests that cover this case.

Also fixes #3632
Copy link

bors bot commented Nov 2, 2023

Build failed:

@galibey
Copy link
Contributor Author

galibey commented Nov 2, 2023

bors retry

bors bot pushed a commit that referenced this pull request Nov 2, 2023
Added cascade deletion for local metadata.

Also, fixed a bug with deserialization failure for nested enums if the outer enum is tagged. More details here dtolnay/serde-yaml#378. Fixed by removing external tagging for versioned spec and added unit-tests that cover this case.

Also fixes #3632
Copy link

bors bot commented Nov 2, 2023

Build failed:

@galibey
Copy link
Contributor Author

galibey commented Nov 3, 2023

bors r+

bors bot pushed a commit that referenced this pull request Nov 3, 2023
Added cascade deletion for local metadata.

Also, fixed a bug with deserialization failure for nested enums if the outer enum is tagged. More details here dtolnay/serde-yaml#378. Fixed by removing external tagging for versioned spec and added unit-tests that cover this case.

Also fixes #3632
Copy link

bors bot commented Nov 3, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: add cascade deletion for local metadata [Merged by Bors] - feat: add cascade deletion for local metadata Nov 3, 2023
@bors bors bot closed this Nov 3, 2023
@galibey galibey deleted the feat/add-cascade-deletion-to-local-metadata branch November 3, 2023 04:49
vrrashkov pushed a commit to vrrashkov/fluvio that referenced this pull request Nov 3, 2023
Added cascade deletion for local metadata.

Also, fixed a bug with deserialization failure for nested enums if the outer enum is tagged. More details here dtolnay/serde-yaml#378. Fixed by removing external tagging for versioned spec and added unit-tests that cover this case.

Also fixes infinyon#3632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: add back local cluster to partitioning tests
2 participants