-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: add cascade deletion for local metadata #3638
[Merged by Bors] - feat: add cascade deletion for local metadata #3638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice job.
Only possible problem I see is that some of tests in the CI were not running reliably with local
mode with previous changes. So need to check if they are running ok once this is merged.
bors r+ |
Added cascade deletion for local metadata. Also, fixed a bug with deserialization failure for nested enums if the outer enum is tagged. More details here dtolnay/serde-yaml#378. Fixed by removing external tagging for versioned spec and added unit-tests that cover this case. Also fixes #3632
Build failed: |
bors retry |
Added cascade deletion for local metadata. Also, fixed a bug with deserialization failure for nested enums if the outer enum is tagged. More details here dtolnay/serde-yaml#378. Fixed by removing external tagging for versioned spec and added unit-tests that cover this case. Also fixes #3632
Build failed: |
bors r+ |
Added cascade deletion for local metadata. Also, fixed a bug with deserialization failure for nested enums if the outer enum is tagged. More details here dtolnay/serde-yaml#378. Fixed by removing external tagging for versioned spec and added unit-tests that cover this case. Also fixes #3632
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Added cascade deletion for local metadata. Also, fixed a bug with deserialization failure for nested enums if the outer enum is tagged. More details here dtolnay/serde-yaml#378. Fixed by removing external tagging for versioned spec and added unit-tests that cover this case. Also fixes infinyon#3632
Added cascade deletion for local metadata.
Also, fixed a bug with deserialization failure for nested enums if the outer enum is tagged. More details here dtolnay/serde-yaml#378. Fixed by removing external tagging for versioned spec and added unit-tests that cover this case.
Also fixes #3632