feat(cli): release date column for package listings #4203

EstebanBorai · 2024-10-02T22:37:19Z

Hub Clients such as:

cdk
fluvio hub connector list (uses same impl as from cdk)
fluvio hub smartmodule list

Should include the release date as part of their listing.

Demo

CleanShot.2024-10-03.at.13.00.19.mp4

sehz · 2024-10-03T14:48:40Z

crates/fluvio-hub-util/src/cmd/list.rs

+ return date.format("%Y-%m-%d %H:%M:%S %Z").to_string();
+ }
+
+ if duration.num_weeks() >= 1 {


This ia already available in humantime crate. No need to reinvent

Yes that was my first attempt, using humantime, but I didn't found a format specifier,FormatDuration doesn't let you pick which fields to use.

And given that release dates are from more that a year in some cases we have outputs like 2years 2min 12us (as shown here: https://docs.rs/humantime/latest/humantime/)

Here is an example of how many packages looked like: 2years 12h 4m 37s 47ms 997us 519ns

https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=933296e2dc7dcd9f93dc91fc75849617

It would be nice to use from years to minutes but thing is that theres no way to specify that.

That's too much. It should be the last value, 2 years, or the last 2 values, 4 days 26 min.

BTW, you can use Kubernetes for hints. The output for accounts has a time value.

Thats correct @ajhunyady! Thank you so much for the suggestions!

I have updated tests to use a static past date and use that for calculations, so dynamic current time doest break them.

Yeah it would be nice to have humantime format support but seems that its not being actively maintained, last commit was 2 years ago: https://github.com/tailhook/humantime

sehz · 2024-10-03T15:17:06Z

crates/fluvio-extension-common/src/common/time.rs

+use chrono::{DateTime, Utc};
+
+pub fn format_duration(date: DateTime<Utc>, exact: bool) -> String {
+ let duration = Utc::now().signed_duration_since(date);


Lets add unit test

Tests provided here: 231efc9

crates/fluvio-extension-common/src/common/time.rs

ajhunyady · 2024-10-03T16:12:02Z

@EstebanBorai can we default to --exact-time? The data alone is not sufficient in most cases.

A nice improvement would be to have human readable values 3 days, or 24 minutes, etc.
And maybe default to that.

EstebanBorai · 2024-10-03T20:18:54Z

@EstebanBorai can we default to --exact-time? The data alone is not sufficient in most cases.

A nice improvement would be to have human readable values 3 days, or 24 minutes, etc. And maybe default to that.

I could make it the default and perhaps later implement the duration since

EstebanBorai · 2024-10-03T20:25:12Z

@sehz @ajhunyady I have updated the formatter so we can inject a comparison date to improve testing. Now tests will not break because we use a fixed date.

With that I think we are good to go?

EstebanBorai · 2024-10-03T20:28:47Z

@EstebanBorai can we default to --exact-time? The data alone is not sufficient in most cases.

A nice improvement would be to have human readable values 3 days, or 24 minutes, etc. And maybe default to that.

Yeah thats the default, in the video we just see the date string output due to the fact that these packages are from more than a month ago

EstebanBorai · 2024-10-03T20:29:29Z

@EstebanBorai can we default to --exact-time? The data alone is not sufficient in most cases.
A nice improvement would be to have human readable values 3 days, or 24 minutes, etc. And maybe default to that.

Yeah thats the default, in the video we just see the date string output due to the fact that these packages are from more than a month ago

Here are tested all variants: https://github.com/infinyon/fluvio/pull/4203/files#diff-779c45328cff39a63747a2e73d809fa7c2e7d8fda7e0e88e5a90fb07b0b5af6aR57-R140

ajhunyady · 2024-10-03T21:05:22Z

Is there a video?

EstebanBorai · 2024-10-03T21:07:26Z

Is there a video?

Yeah! On the top in the PR description Im showing both use cases (exact and not exact) and also for connectors and smart modules.

sehz · 2024-10-03T22:58:44Z

crates/fluvio-cli/src/client/hub/smartmodule/list.rs

@@ -81,7 +98,7 @@ mod output {
 impl TableOutputHandler for ListSmartModules {
 /// table header implementation
 fn header(&self) -> Row {
- Row::from(["SMARTMODULE", "Visibility"])
+ Row::from(["SmartModule", "Visibility", "Released"])


should be published since there there is no concept of released concept in hub

Sounds good! Applied here: ba6348a

crates/fluvio-cli/src/client/hub/smartmodule/list.rs

sehz · 2024-10-03T23:03:29Z

crates/fluvio-extension-common/src/common/time.rs

+ .expect("failed to set min");
+ let formatted = make_fixed_time_elapsed_fmtr().time_since_str(date, true);
+
+ assert_eq!(formatted, date.format(EXACT_FORMAT).to_string());


test should have assertion like this:

assert_eq!(date,"December 1989");

Of course! Here is the update: 0a4d54a

sehz · 2024-10-03T23:03:53Z

crates/fluvio-extension-common/src/common/time.rs

+ .expect("failed to sub days");
+ let formatted = make_fixed_time_elapsed_fmtr().time_since_str(date, false);
+
+ assert_eq!(formatted, date.format(SIMPLE_DATE_FORMAT).to_string());


see comments above

Sure! I did it here: 0a4d54a

sehz · 2024-10-03T23:04:09Z

crates/fluvio-hub-util/src/cmd/list.rs

@@ -78,7 +91,7 @@ mod output {
 impl TableOutputHandler for ListConnectors {
 /// table header implementation
 fn header(&self) -> Row {
- Row::from(["CONNECTOR", "Visibility"])
+ Row::from(["Connector", "Visibility", "Released"])


Published

Probably Connector -> Versions

Updated the Published already! About Versions I think that would belong to a new column doesn't it? Perhaps as an iteration from this we could split name from version and use a column for versions only?

sehz · 2024-10-04T01:06:36Z

crates/fluvio-extension-common/src/common/time.rs

+ .expect("failed to sub days");
+ let formatted = make_fixed_time_elapsed_fmtr().time_since_str(date, false);
+
+ assert_eq!(formatted, "1989/12/10");


why it is different from determines_exact_date
Shouldn't it be 1989/12/10 00:00::00 UTC ?

Its just simpler to keep it compact, an output including time and thus timezone (e.g. 1989/12/10 00:00::00 UTC) would only appear if user uses exact-date.

Do you rather using exact date as fallback for longer periods?

I thought it automatically converts to exact if exceed certain time. This is only 7 days, so shouldn't be a week or something like that?

We could have week counter yeah, perhaps we should set boundaries?
I think we could render exact date for more than a year? Otherwise show months, weeks and days?

There is well established library like: https://www.npmjs.com/package/humanize-duration that specifies behavior

sehz · 2024-10-04T01:50:33Z

crates/fluvio-extension-common/src/common/time.rs

+ Self { bot }
+ }
+
+ pub fn time_since_str(&self, date: DateTime<Utc>, exact: bool) -> String {


should add docs on rule

Here I have added docs: e96128c, I will use such statements in the docs as guide for free-form expressions.

EstebanBorai linked an issue Oct 2, 2024 that may be closed by this pull request

CDK: List release date #4185

Open

EstebanBorai force-pushed the 4185-cdk-list-release-date branch 4 times, most recently from 27b79dd to f72d62a Compare October 2, 2024 22:42

EstebanBorai changed the title ~~feat(cdk): hub list should include release date~~ feat(hub): hub lists should include release date Oct 2, 2024

EstebanBorai changed the title ~~feat(hub): hub lists should include release date~~ feat(hub): package listings column for release date Oct 2, 2024

EstebanBorai changed the title ~~feat(hub): package listings column for release date~~ feat(hub): release date column for package listings Oct 2, 2024

feat(cdk): hub list should include release date

0c223eb

EstebanBorai force-pushed the 4185-cdk-list-release-date branch from f72d62a to 0c223eb Compare October 3, 2024 14:38

sehz reviewed Oct 3, 2024

View reviewed changes

chore: centralize format algorithm in extension common

eb6b665

sehz reviewed Oct 3, 2024

View reviewed changes

EstebanBorai added 2 commits October 3, 2024 12:56

chore: tests for time rendering

231efc9

chore: bump fluvio-extension-common

69c0de3

EstebanBorai changed the title ~~feat(hub): release date column for package listings~~ feat(cli): release date column for package listings Oct 3, 2024

EstebanBorai requested a review from sehz October 3, 2024 16:06

sehz reviewed Oct 3, 2024

View reviewed changes

crates/fluvio-extension-common/src/common/time.rs Show resolved Hide resolved

fix: use static date for tests

2ecee7a

EstebanBorai requested review from sehz and ajhunyady October 3, 2024 22:02

sehz reviewed Oct 3, 2024

View reviewed changes

crates/fluvio-cli/src/client/hub/smartmodule/list.rs Show resolved Hide resolved

sehz reviewed Oct 3, 2024

View reviewed changes

EstebanBorai added 3 commits October 3, 2024 21:41

feat: use Published instead of Released

ba6348a

fix: update docs in cli

d6e8987

fix: update tests to use str

0a4d54a

EstebanBorai requested a review from sehz October 4, 2024 00:48

sehz reviewed Oct 4, 2024

View reviewed changes

EstebanBorai added 2 commits October 4, 2024 12:56

chore: update docs

e96128c

Merge branch 'master' into 4185-cdk-list-release-date

9051393

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cli): release date column for package listings #4203

feat(cli): release date column for package listings #4203

EstebanBorai commented Oct 2, 2024 •

edited

Loading

sehz Oct 3, 2024

EstebanBorai Oct 3, 2024

EstebanBorai Oct 3, 2024

ajhunyady Oct 3, 2024 •

edited

Loading

ajhunyady Oct 3, 2024 •

edited

Loading

EstebanBorai Oct 3, 2024

sehz Oct 3, 2024

EstebanBorai Oct 3, 2024

EstebanBorai Oct 3, 2024

ajhunyady commented Oct 3, 2024

EstebanBorai commented Oct 3, 2024

EstebanBorai commented Oct 3, 2024

EstebanBorai commented Oct 3, 2024

EstebanBorai commented Oct 3, 2024

ajhunyady commented Oct 3, 2024

EstebanBorai commented Oct 3, 2024

sehz Oct 3, 2024

EstebanBorai Oct 4, 2024

sehz Oct 3, 2024

EstebanBorai Oct 4, 2024

sehz Oct 3, 2024

EstebanBorai Oct 4, 2024

sehz Oct 3, 2024

sehz Oct 3, 2024

EstebanBorai Oct 4, 2024

sehz Oct 4, 2024 •

edited

Loading

EstebanBorai Oct 4, 2024

sehz Oct 4, 2024

EstebanBorai Oct 4, 2024

sehz Oct 4, 2024

sehz Oct 4, 2024

EstebanBorai Oct 4, 2024

feat(cli): release date column for package listings #4203

Are you sure you want to change the base?

feat(cli): release date column for package listings #4203

Conversation

EstebanBorai commented Oct 2, 2024 • edited Loading

Demo

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ajhunyady Oct 3, 2024 • edited Loading

Choose a reason for hiding this comment

ajhunyady Oct 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ajhunyady commented Oct 3, 2024

EstebanBorai commented Oct 3, 2024

EstebanBorai commented Oct 3, 2024

EstebanBorai commented Oct 3, 2024

EstebanBorai commented Oct 3, 2024

ajhunyady commented Oct 3, 2024

EstebanBorai commented Oct 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sehz Oct 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EstebanBorai commented Oct 2, 2024 •

edited

Loading

ajhunyady Oct 3, 2024 •

edited

Loading

ajhunyady Oct 3, 2024 •

edited

Loading

sehz Oct 4, 2024 •

edited

Loading