Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search $FLUVIO_DIR and $HOME/.fluvio/extensions for extension executable #508

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

simlay
Copy link
Contributor

@simlay simlay commented Nov 23, 2020

This will close #500.

@simlay simlay marked this pull request as ready for review November 23, 2020 20:48
@simlay simlay force-pushed the cli-search-only-extensions-directory branch 2 times, most recently from 374ef53 to 308c2de Compare November 24, 2020 00:55
@simlay simlay requested a review from sehz November 24, 2020 02:37
@simlay simlay force-pushed the cli-search-only-extensions-directory branch from 308c2de to 9ae6891 Compare November 24, 2020 02:43
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. What about removing warning about PATH in the installer?

@simlay
Copy link
Contributor Author

simlay commented Nov 24, 2020

What about removing warning about PATH in the installer?

Whoops. Forgot about that. Where do we want the installer to install to? /usr/local/bin? I actually kinda like it getting installed at ~/.fluvio/bin.

@sehz
Copy link
Contributor

sehz commented Nov 24, 2020

What about removing warning about PATH in the installer?

Whoops. Forgot about that. Where do we want the installer to install to? /usr/local/bin? I actually kinda like it getting installed at ~/.fluvio/bin.

I see. if it is installed at ~/.fluvio/bin, we still need have user modify PATH

@simlay simlay force-pushed the cli-search-only-extensions-directory branch from 9ae6891 to 07021e4 Compare November 24, 2020 04:32
@sehz sehz merged commit 13ec1d6 into infinyon:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension: Use CLI to search only extension folder
2 participants