Remove optional in DefaultAsyncRecord. #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simlay
commented
Jan 21, 2021
sehz
requested changes
Jan 21, 2021
sehz
reviewed
Jan 21, 2021
simlay
force-pushed
the
remove-optional-in-record
branch
2 times, most recently
from
92f5048
to
7c99a0b
Compare
sehz
requested changes
Jan 21, 2021
simlay
force-pushed
the
remove-optional-in-record
branch
from
7c99a0b
to
b61d6c1
Compare
sehz
requested changes
Jan 22, 2021
simlay
force-pushed
the
remove-optional-in-record
branch
from
b61d6c1
to
b6d8484
Compare
|
One of the tests is failing at the |
simlay
force-pushed
the
remove-optional-in-record
branch
from
b6d8484
to
d352800
Compare
What's error message? |
simlay
force-pushed
the
remove-optional-in-record
branch
3 times, most recently
from
878958e
to
9018214
Compare
sehz
requested changes
Jan 23, 2021
simlay
force-pushed
the
remove-optional-in-record
branch
2 times, most recently
from
0998db1
to
bf6420c
Compare
simlay
commented
Jan 25, 2021
| @@ -28,7 +28,7 @@ inputs: | |||
| minikube-version: | |||
| description: "Use a specific minikube version" | |||
| required: false | |||
| default: 'v1.13.1' | |||
| default: 'v1.17.0' | |||
There was a problem hiding this comment.
I bumped this hoping that it'll stabilize the CI on github runners.
simlay
force-pushed
the
remove-optional-in-record
branch
2 times, most recently
from
a68ee97
to
90b2b24
Compare
sehz
approved these changes
Jan 25, 2021
simlay
force-pushed
the
remove-optional-in-record
branch
from
90b2b24
to
9f04ac9
Compare
simlay
force-pushed
the
remove-optional-in-record
branch
from
9f04ac9
to
c68b340
Compare
simlay
force-pushed
the
remove-optional-in-record
branch
from
c68b340
to
a88b382
Compare
sehz
approved these changes
Jan 26, 2021
sehz
pushed a commit
to sehz/fluvio
that referenced
this pull request
Feb 2, 2021
This was referenced Feb 5, 2021
simlay
added a commit
that referenced
this pull request
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dependent on infinyon/fluvio-protocol#4 but I've written the refactor using a work around.Depends on infinyon/fluvio-protocol#5
We should also probably rename
try_into_bytestobytes.Record updates:
AsRefimplementationas_ref()returns&[u8]to_utf8_lossy(returns a string)to_bytestakes ownership and returns aVec<u8>impl TryFrom<Record> for String