CLI Key/Value interface #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
nicholastmosher
force-pushed
the
key-value-cli
branch
2 times, most recently
from
ec2dc5c
to
d4858b5
Compare
4 tasks
nicholastmosher
force-pushed
the
key-value-cli
branch
3 times, most recently
from
6397136
to
30315e1
Compare
nicholastmosher
force-pushed
the
key-value-cli
branch
2 times, most recently
from
cc91b01
to
fb5a707
Compare
Update documentation of CLI producer Print status for each record produced, unless -q
nicholastmosher
force-pushed
the
key-value-cli
branch
from
f06ac4a
to
d4ffb1c
Compare
sehz
requested changes
Mar 9, 2021
| @@ -34,6 +48,10 @@ pub struct ConsumeLogOpt { | |||
| #[structopt(short = "d", long)] | |||
| pub disable_continuous: bool, | |||
|
|
|||
| /// Print records in "[key] value" format, with "[null]" for no key | |||
| #[structopt(short, long)] | |||
| pub key_value: bool, | |||
There was a problem hiding this comment.
This has the structopt(short), which means we can use --key-value or -k
There was a problem hiding this comment.
actually, this flag is confusing. it sounds like it is about consuming. it should be more like: --print-kv-header. Also printing key should be default so in this case, it should be -disable-print-kv-header
There was a problem hiding this comment.
Originally I had made the consumer print keys by default, but @ajhunyady said he preferred otherwise. I don't have a preference one way or the other. Let me know what you guys decide.
sehz
requested changes
Mar 9, 2021
nicholastmosher
force-pushed
the
key-value-cli
branch
from
73fc088
to
6acc582
Compare
nicholastmosher
force-pushed
the
key-value-cli
branch
from
680770f
to
038916b
Compare
|
@sehz I think all of the changes have been added. I'm ready to merge this if you are 👍 |
simlay
pushed a commit
that referenced
this pull request
Mar 16, 2021
* Producer CLI with --lines Update documentation of CLI producer Print status for each record produced, unless -q * Add initial Key/Value support to CLI producer and consumer * Apply cargo clippy * Add support for JSON Key/Value with jsonpath * Update producer printout * Update consumer key/value printout formatting * Update interactive printout for producer and consumer * Remove --partition from producer * Add --key-value to consumer CLI * Update help menu for consumer CLI * Condense producer CLI code * Remove --json-path from producer CLI * Review: update tracing and error printout in consumer * Remove multi-file support for producer * Remove 'Reading one record per line from stdin' prompt * Default producer behavior to always be line-by-line * Update producer help * Fix double-printing produced lines * Fixed printout for producer interactive mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a key/value interface for the producer and consumer CLI. Should not be merged before #828.
The first draft of the documentation for these CLI changes is here: infinyon/fluvio-website#58