Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix issue where topic delete is not completed when SPU goes offline.
Steps to reproduce and test:
Build and Set up Cluster
Kill SPU in the local cluster
Delete topic with SPU offline.
This will hang, so you have to press ^c
The topic
test
will be delete mode but not removed because of finalizerSPU logs
Restarting SPU will complete delete
Topics are gone:
And topic log directories are gone as well: