This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
feat(csi-415): avoid ISPA crash loop on starting. refactoring to add new abstraction - PeerServer #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(csi-445): added PeerServer; updated AppConfig; fixed tests
geka-evk
changed the title
feat(csi-415): avoid crash loop in inter-scheme-proxy-adapter
feat(csi-415): refactoring to add new abstraction - PeerServer
Aug 6, 2024
vijayg10
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed at high level as it seems major refactor. LGTM.
kalinkrustev
approved these changes
Aug 7, 2024
feat(csi-446): avoid crash loop in inter-scheme-proxy-adapter during start
geka-evk
changed the title
feat(csi-415): refactoring to add new abstraction - PeerServer
feat(csi-415): avoid ISPA crash loop on starting. refactoring to add new abstraction - PeerServer
Aug 7, 2024
feat(csi-415): fixed ControlAgent.close() hanging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new abstraction
PeerServer
to manage eachpeer
initialization independently.Class diagram