Skip to content

Conversation

crepererum
Copy link

@crepererum crepererum commented Jun 20, 2025

This is #54 with less patches, rebased on version 46.0.1.

…rceDistribution) which later causes an error during EnforceSort (without our patch). The next DataFusion version 46 upgrade does the proper fix, which is to not insert the coalesce in the first place.

test: recreating the iox plan:
* demonstrate the insertion of coalesce after the use of column estimates, and the removal of the test scenario's forcing of rr repartitioning

test: reproducer of SanityCheck failure after EnforceSorting removes the coalesce added in the EnforceDistribution

fix: special case to not remove the needed coalesce
@crepererum
Copy link
Author

The last patch shouldn't be required for this DF version but it is (also see slack). I'm going to try to clean this up AFTER the upgrade, since things seem to work fine with it.

@alamb
Copy link
Collaborator

alamb commented Jun 23, 2025

Close/reopen to run tests

@alamb alamb closed this Jun 23, 2025
@alamb alamb reopened this Jun 23, 2025
@crepererum
Copy link
Author

replaced by #66

@crepererum crepererum closed this Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants