Patched object_store 0.12.2 (take 1) #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crepererum
force-pushed
the
upgrade-object-store-ver0122-a
branch
from
08a626c to
42773ac
Compare
crepererum
force-pushed
the
upgrade-object-store-ver0122-a
branch
from
42773ac to
bd3b6c5
Compare
* ci: Pin tracing-attributes to fix CI * Pin tracing-core
This used to work once but got broken during refactoring. Added a test to catch regressions. See apache#48 where -- I think -- we decided that instead of printing entire error chains in `Display` the API users shall walk the error chain. This is especially relevant for error type that we do NOT control, like upstream `request` types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: https://github.com/influxdata/influxdb_iox/issues/14640
Patches
Patches map to commits 1:1 (i.e. every patch is exactly 1 commit) and are ordered for easier correlation of the description and the respective commits. They are also grouped in 3 stages.
A: Dummy
No actual patches, can be dropped at any point:
B: CI Fixes
Need to get CI up and running before picking any actual patches:
chore: fix clippy 1.88 warnings:That's chore: fix clippy 1.88 warnings apache/arrow-rs-object-store#418 backported. Can be dropped with
object_store0.13.minor: Pin tracing-attributes, tracing-core to fix CI:That's minor: Pin
tracing-attributes,tracing-coreto fix CI apache/arrow-rs-object-store#404 backported. Can be dropped withobject_store0.13.All commits afterwards should build cleanly!
C: Patches
These are the actual relevant patches:
fix: expose source of RetryError:That's fix: expose source of
RetryErrorapache/arrow-rs-object-store#422 . Should be included inobject_store0.13.