Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host Pages can't be navigated to when --basepath is used #1388

Closed
jaredscheib opened this issue May 3, 2017 · 2 comments
Closed

Host Pages can't be navigated to when --basepath is used #1388

jaredscheib opened this issue May 3, 2017 · 2 comments
Labels
needs more info

Comments

@jaredscheib
Copy link
Contributor

jaredscheib commented May 3, 2017 •
edited
Loading

Possibly due to react-router deprecating location.query: remix-run/react-router#3336

It should still fail but seems to work (though there are no query params?) when loading a Host Page when --basepath is not enabled.
@jaredscheib jaredscheib changed the title AJAX requests called directly by components fail when user uses 'basepath' config option Host Pages can't be navigated to when --basepath is enabled May 4, 2017
@jaredscheib jaredscheib changed the title Host Pages can't be navigated to when --basepath is enabled Host Pages can't be navigated to when --basepath is used May 4, 2017
@nhaugo nhaugo added this to the 1.3.3 milestone Jun 13, 2017
@nhaugo
Copy link
Contributor

nhaugo commented Jun 13, 2017

Can we try to reproduce this @jaredscheib or @timraymond

@nhaugo nhaugo modified the milestones: Uncommitted, 1.3.3 Jun 13, 2017
@russorat
Copy link
Contributor

i don't see this problem in the latest builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs more info
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nhaugo @russorat @jaredscheib