-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.0] Remove deprecated code #3336
Comments
Set up a 2.x branch that we can put stuff on after 3.0 is out. I don't think we need ones for 2.0.x, 2.1.x, 2.2.x, etc. In order to avoid the hassles and confused issues while we waited on 2.0, we should keep master as 2.x until we're either at or near a 3.0.0 release. It's more annoying for us as developers, but it's also annoying having to close tons of issues because of confusion over docs and code changes. |
The next major release should go on a rolling In practice it's not that confusing to users (since only people close enough to the code to actually follow the repo will see it), and it's less book-keeping for us. If we're really ambitious, we could just set up the deprecation removals on that branch right now, and cut pre-releases on an ongoing basis. |
Working on that at the moment. Updated the |
Re: The (P.S. Yes, @taion, CircleCI is many times better than Travis. I've got to talk Dan into using it for Redux. The speedups over there would be quite notable.) |
OK, they're all in #3340. |
Found some more. Added to the OP. But it's bedtime, so if someone else wants to get them, go nuts! |
@timdorr The rule of thumb is that stuff that people use a lot should stay deprecated for longer. The |
BTW, lets go with merging between |
That makes sense to me. |
This issue tracks the things that need to be deprecated. I'd like to have an issue for each one of these. Also, moving forward, when we deprecate an API, we need to immediately make an issue and assign it to the milestone when we are going to completely remove it.
Here's the list, please edit and add anything I'm missing.
context.location
,context.history
useRouterHistory
query
,params
, etc)getComponents
first argumentuseRoute
(the warning says to usecreateTransitionManager
but I don't think that's right, seems like they should useuseRouterHistory
but I don't know the history of that warning,transitionManager
seems like implementation, not API)isActive(pathname, query, indexOnly)
increateTransitionManager
and ``replaceState(state, pathname, query)in
runTransitionHooks`After we cut our next minor release (https://github.com/reactjs/react-router/milestones/next-2.3.0), we'll create a 3.0 branch to start working on this stuff, that way we can still make bug fix releases on 2.3 from master. To keep our promise to not make major releases more often than every 3 months, we can release 3.0 on May 9-ish.
The text was updated successfully, but these errors were encountered: