Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jteeuwen/go-bindata to kevinburke/go-bindata #2785

Merged
merged 2 commits into from
Feb 8, 2018
Merged

Conversation

e-dard
Copy link
Contributor

@e-dard e-dard commented Feb 8, 2018

  • Rebased/mergable
  • Tests pass

Connect jteeuwen/go-bindata#3

The problem

Chronograf relies on go-bindata within its toolchain. Recently, the author of jteeuwen/go-bindata deleted their Github account. Someone who needed that repo and who couldn't update their dependencies to a fork signed up to Github with the jteeuwen username and reinstated the repo. While probably innocuous it's dubious at best.

jteeuwen/go-bindata also hasn't been updated since ~2015.

The Solution

Rather than relying on jteeuwen/go-bindata, which may or may not disappear again or be otherwise fiddled with, it might be best to rely on a well-maintained fork.

@kevinburke maintains a fork over at https://github.com/kevinburke/go-bindata, which has had some recent commits and bug fixes. I often see @kevinburke in the Go community (Slack, Twitter etc), so I think it would be fine to rely on that fork instead.

In doing so a lot of vendored stuff got updated 😭. Someone will have to wade through that...

@goller goller self-requested a review February 8, 2018 16:06
@goller goller merged commit ca0e394 into master Feb 8, 2018
@goller goller deleted the er-go-bindata branch February 8, 2018 16:29
@kevinburke
Copy link

Thanks for this! I'm committed to maintaining this, if it gives you any problems please let me know. Notably I added a digest feature which lets you easily retrieve the checksum of a given file - you can use this for cache busting or to protect against memory corruption.

@goller
Copy link
Contributor

goller commented Feb 8, 2018

@kevinburke oh that's great! I'll switch to that for ETag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants