Update jteeuwen/go-bindata to kevinburke/go-bindata #2785
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect jteeuwen/go-bindata#3
The problem
Chronograf relies on
go-bindata
within its toolchain. Recently, the author ofjteeuwen/go-bindata
deleted their Github account. Someone who needed that repo and who couldn't update their dependencies to a fork signed up to Github with the jteeuwen username and reinstated the repo. While probably innocuous it's dubious at best.jteeuwen/go-bindata
also hasn't been updated since ~2015.The Solution
Rather than relying on
jteeuwen/go-bindata
, which may or may not disappear again or be otherwise fiddled with, it might be best to rely on a well-maintained fork.@kevinburke maintains a fork over at https://github.com/kevinburke/go-bindata, which has had some recent commits and bug fixes. I often see @kevinburke in the Go community (Slack, Twitter etc), so I think it would be fine to rely on that fork instead.
In doing so a lot of vendored stuff got updated 😭. Someone will have to wade through that...