Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): respect BASE_PATH when serving API docs #5862

Merged
merged 2 commits into from
Feb 12, 2022

Conversation

mmdoogie
Copy link
Contributor

@mmdoogie mmdoogie commented Feb 11, 2022

Absolute path to swagger.json in the served docs route did not respect BASE_PATH from config.
Changed to relative path to resolve.

Absolute path to file did not respect BASE_PATH from config.
@mmdoogie mmdoogie force-pushed the docs-basepath branch 2 times, most recently from ac1c68c to 641afbb Compare February 11, 2022 19:02
@mmdoogie mmdoogie closed this Feb 11, 2022
@mmdoogie mmdoogie reopened this Feb 11, 2022
@mmdoogie mmdoogie marked this pull request as ready for review February 11, 2022 21:06
@sranka sranka changed the title fix(server): Respect BASE_PATH when serving API docs fix(server): respect BASE_PATH when serving API docs Feb 12, 2022
Copy link
Contributor

@sranka sranka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you for your contribution

@sranka sranka merged commit 09b74fa into influxdata:master Feb 12, 2022
@ivankudibal ivankudibal added this to the 1.9.4 milestone Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants