Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): separate flux tasks list from alerts #5868

Merged
merged 24 commits into from
Feb 22, 2022
Merged

feat(ui): separate flux tasks list from alerts #5868

merged 24 commits into from
Feb 22, 2022

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Feb 17, 2022 •
edited
Loading

This PR separates/moves kapacitor's flux task list from the alerts page to a separate page, it is a required pre-requisite to #5460.

  • Flux Tasks is a new menu item in the side bar:
    image
  • The page contains a table of Flux Tasks that was before on the Alert Rules page
    image
  • The Page let the user also filter Flux tasks by name and perform a manual Refresh
  • Flux tasks are available since Kapacitor 1.6 and must be enabled in its config, the UI
    image
  • Exiting a page of a particular Flux Task editor returns the user to the Flux Tasks page (was Alert Rules)

Additionally, the sidebar was fixed so that Alerting is highlighted when flux tasks, kapactior alert tule or TICKScript pages are shown.

@sranka sranka self-assigned this Feb 17, 2022
@sranka sranka force-pushed the feat/separated_flux_tasks branch from 0b4a1df to a6b825e Compare February 17, 2022 13:44
sranka added 16 commits February 17, 2022 15:20
@sranka
chore(ui): rename activeKapacitorFromSources helper
10455c3
@sranka
feat(ui): introduce errorMessage utility
2c3b490
@sranka
feat(ui): add useDebounce helper
6d9e333
@sranka
feat(ui): add independent Flux Tasks page
cc34b79
@sranka
feat(ui): filter fetched flux tasks
4d33440
@sranka
feat(ui): delete a flux task without re-fetch
ed7e73d
@sranka
feat(ui): disable filtering when loading
54cccda
@sranka
feat(ui): add reload button to flux tasks
52da3a9
@sranka
feat(ui): remove flux tasks table from rules page
94138a5
@sranka
feat(ui): return to Flux Tasks page on exiting Flux Task Page
8101fbe
@sranka
feat(ui): optimize flux tasks retrieval
2a1e5b1
@sranka
feat(ui): highlight flux tasks in side navigation
29ba42c
@sranka
feat(ui): add flux tasks to navigation sidebar
cfb255b
@sranka
feat(ui): configure negative rules in sidebar highlighting
5e8fe55
@sranka
fix(ui): repair ativation of side navigation for kapacitor task detai…
fd90be6 
…l pages
@sranka
feat(ui): separate kapacitor flux tasks API
72378f7
@sranka sranka force-pushed the feat/separated_flux_tasks branch from b7a1079 to 72378f7 Compare February 17, 2022 14:20
@sranka sranka requested a review from ivankudibal February 18, 2022 08:18
@sranka sranka marked this pull request as ready for review February 18, 2022 08:18
@sranka sranka added this to the 1.9.4 milestone Feb 22, 2022
@sranka sranka merged commit 51c506c into master Feb 22, 2022
@sranka sranka deleted the feat/separated_flux_tasks branch February 22, 2022 13:55
@sranka sranka mentioned this pull request Mar 11, 2022
Merged
4 tasks
@ivankudibal ivankudibal removed their request for review March 22, 2022 19:50
@lwandzura lwandzura mentioned this pull request Mar 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlastahajek vlastahajek vlastahajek approved these changes

Assignees

@sranka sranka

Labels
None yet
Projects
None yet
Milestone
1.9.4
Development

Successfully merging this pull request may close these issues.
2 participants
@sranka @vlastahajek