Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ResourceName TestID issue #481

Merged
merged 3 commits into from
Apr 10, 2020
Merged

Fix ResourceName TestID issue #481

merged 3 commits into from
Apr 10, 2020

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Apr 10, 2020 •
edited
Loading

Closes #478

Changes

  • Ensure testID and onClick are attached to the same DOM element

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

mavarius
mavarius approved these changes Apr 10, 2020
View reviewed changes
Copy link
Collaborator

@mavarius mavarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@alexpaxton alexpaxton merged commit 46bb05a into master Apr 10, 2020
@alexpaxton alexpaxton deleted the fix/resource-card-testid branch April 10, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavarius mavarius mavarius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource Card Editable Name TestID is not on clickable element
2 participants
@alexpaxton @mavarius