feat: make sure the query plan nodes have unique ids #3297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3297 +/- ##
=======================================
Coverage 49.35% 49.35%
=======================================
Files 351 351
Lines 36379 36393 +14
=======================================
+ Hits 17954 17962 +8
- Misses 15904 15908 +4
- Partials 2521 2523 +2
Continue to review full report at Codecov.
|
rockstar
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
Thanks for the description here. I had assumed something similar, but I'm glad to see it explicit. Also, this patch looks much more narrow than the previous one, and can fit in my brain a lot better. Thanks for doing that for me. Let's go ahead and merge this here good work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of our planner rules transform the existing plan nodes into completely different ones. For example,
PushDownGroupAggregateRulecollapsesrange |> window |> aggintoReadWindowAggregate.In this process, we usually manually create the new physical nodes without numbering them. So if such planner rules are applied more than once in a query (a query with join or table functions or
chain()), the plan nodes those rules created will have the same node ID and thus the same dataset ID. This will confuse the execution engine and generate undefined results.This PR addresses it by introducing a new
CreateUniquePhysicalNodemethod that can read the next plan node ID from the context and apply it.