fix(execute): use random dataset ids instead of ones hashed from the name #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name The executor would create the dataset id by using the plan node name. While plan node names are usually unique, they aren't necessarily guaranteed to be unique. This would cause multiple datasets to have the same id and could cause a conflict. This further protects against that situation by changing uuid generation for dataset ids to use the v4 algorithm which uses a random number generator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The executor would create the dataset id by using the plan node name.
While plan node names are usually unique, they aren't necessarily
guaranteed to be unique. This would cause multiple datasets to have the
same id and could cause a conflict.
This further protects against that situation by changing uuid generation
for dataset ids to use the v4 algorithm which uses a random number
generator.
Fixes #3053.
Done checklist