fix(execute): remove 64bit misalignment #4676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `atomic.LoadUint64(()` on `groupKey.hash` resulted in an alignment panic in armv7, due to it not being 64bit aligned. Declaring it first in the struct solved it. See https://pkg.go.dev/sync/atomic#pkg-note-BUG fore more details For context: I already fixed a similar issue at influxdata/influxdb#23260
scbrickley
approved these changes
Apr 18, 2022
jsternberg
approved these changes
Apr 19, 2022
2opremio
added a commit
to 2opremio/flux-1
that referenced
this pull request
Mar 1, 2023
Invoking atomic operations in the reference counters resulted in an alignment panic in armv7, due to them not being 64bit aligned. Declaring them first in the struct solved it. See https://pkg.go.dev/sync/atomic#pkg-note-BUG fore more details For context: I already fixed a similar issue at influxdata#4676
5 tasks
appletreeisyellow
pushed a commit
that referenced
this pull request
Mar 1, 2023
Invoking atomic operations in the reference counters resulted in an alignment panic in armv7, due to them not being 64bit aligned. Declaring them first in the struct solved it. See https://pkg.go.dev/sync/atomic#pkg-note-BUG fore more details For context: I already fixed a similar issue at #4676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
atomic.LoadUint64(()ongroupKey.hashresulted in an alignment panic in armv7, due to it not being 64bit aligned.Declaring it first in the struct solved it.
See https://pkg.go.dev/sync/atomic#pkg-note-BUG fore more details
For context: I already fixed a similar issue at influxdata/influxdb#23260
Done checklist