feat: add parameter to histogramQuantile #5386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5385.
This adds a parameter to
histogramQuantile
that will let the user decide upon an alternative behavior when bin counts are not monotonically increasing.Currently only"error"
is supported in this PR, I just wanted to get a bit of feedback before I do more.As described in the Flux stdlib doc comments, this adds a parameter called
onNonmonotonic
that accepts three values:error
(default)force
drop
@sanderson Do you have any thoughts on this approach? My thinking is that we have a similar parameter for
filter
calledonEmpty
, so I'm kind of following that pattern.Checklist
Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.
experimental/
docs/Spec.md
has been updatedDear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.