fix(arrow): allow the memory allocator to be nil for arrow arrays #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the memory allocator is nil, that means we don't care to track the memory usage and it will pass the default go allocator directly instead of acting as a proxy.
affo
approved these changes
Jan 3, 2019
jsternberg
added a commit
that referenced
this pull request
Jan 7, 2019
The memory allocator is now optional for the arrow builders so we can pass nil if we don't care to track memory usage. This functionality was added in #610, but this code was added after the PR was tested so this specific test code wasn't caught and changed.
jsternberg
added a commit
that referenced
this pull request
Jan 7, 2019
The memory allocator is now optional for the arrow builders so we can pass nil if we don't care to track memory usage. This functionality was added in #610, but this code was added after the PR was tested so this specific test code wasn't caught and changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the memory allocator is nil, that means we don't care to track the
memory usage and it will pass the default go allocator directly instead
of acting as a proxy.