fix(control): fix a flaky test in the controller shutdown #612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few problems in the controller shutdown test that caused it
to be flaky.
First, it didn't wait for all 10 queries to get into the controller
queue before checking the queue length. This caused it to call
Fatal
and abort the test, but
Shutdown
had already been called and theactive queries needed to be finished.
After that, it attempted to run a query before the shutdown may have
been initiated so the query got enqueued correctly even though it was
not expecting that to happen. It now attempts to create the query and
tries multiple times to get the failure with a wait in between if it
can't.
It now succeeds when run with the following command line:
I was able to reproduce the issue by using the above.
Fixes #611.