Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stdlib): count nulls in the count aggregate #834

Merged
merged 1 commit into from
Jan 14, 2019
Merged

fix(stdlib): count nulls in the count aggregate #834

merged 1 commit into from
Jan 14, 2019

Conversation

jsternberg
Copy link
Contributor

@jsternberg jsternberg commented Jan 14, 2019 •
edited
Loading

  • docs/SPEC.md updated
  • Test cases written

Fixes #831.

@jsternberg jsternberg force-pushed the fix/count-nulls branch 2 times, most recently from c71fdf7 to 9c0db67 Compare January 14, 2019 20:06
@aanthony1243 aanthony1243 self-requested a review January 14, 2019 20:29
aanthony1243
aanthony1243 suggested changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@aanthony1243 aanthony1243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed offline, we need to revisit how we deal with empty/null tables to facilitate proper counting.

aanthony1243
aanthony1243 approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@aanthony1243 aanthony1243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed offline: some of these functions lack adequate null support, and so the "all null" cases for several of these functions will be wrong. however, the basic overall approach is correct, and can be merged.

@jsternberg
fix(stdlib): count nulls in the count aggregate
0311c94 
This refactors aggregates so they will have an `IsNull() bool` function.
If this returns true, then the aggregate is a null value instead of a
real one.
@jsternberg jsternberg merged commit 6e939e8 into master Jan 14, 2019
@jsternberg jsternberg deleted the fix/count-nulls branch January 14, 2019 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanthony1243 aanthony1243 aanthony1243 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsternberg @aanthony1243