Auth job variables #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@naseemkullah Please review. |
naseemkullah
previously approved these changes
Feb 27, 2020
rawkode
previously approved these changes
Feb 27, 2020
|
@jrob could you rebase this against master please? Thank you for your contributions 👍 |
jrob
force-pushed
the
auth-job-variables
branch
from
0cb84df to
ded676d
Compare
|
@rawkode Glad to help out. Rebased. |
naseemkullah
approved these changes
Feb 27, 2020
rawkode
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds to variables for configuration of the post install auth job. This is to help in scenarios where the installation is taking longer but will eventually finish if given more time.
Special notes for your reviewer:
Both of the variables default to either the previous value or the kubernetes default value.