Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add InfluxDB2 Chart #35

Merged
merged 1 commit into from
Mar 19, 2020
Merged

feat: Add InfluxDB2 Chart #35

merged 1 commit into from
Mar 19, 2020

Conversation

rawkode
Copy link
Contributor

@rawkode rawkode commented Mar 5, 2020

No description provided.

@rawkode rawkode marked this pull request as ready for review March 5, 2020 18:42
goller
goller suggested changes Mar 5, 2020
View reviewed changes
Copy link

@goller goller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good... I have a few small nits

charts/influxdb2/templates/job-setup-admin.yaml Outdated Show resolved Hide resolved
charts/influxdb2/templates/statefulset.yaml Outdated Show resolved Hide resolved
russorat
russorat previously approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@russorat russorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to try this!

gianarb
gianarb previously approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@gianarb gianarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing more to add from what the other reviewer said

@naseemkullah
Copy link
Collaborator

If you have the bandwidth, running helm create influxdb-2 (with latest version of helm) will result in better boilerplate (selector label helpers, serviceaccount, image tag equal to chart's app version) and build from there.

@rawkode
Copy link
Contributor Author

rawkode commented Mar 7, 2020

I did use helm create ☹️

I'll recreate it on Monday and fix up the other suggestions

@rawkode rawkode dismissed stale reviews from gianarb and russorat via 73d820d March 18, 2020 12:56
@rawkode
Copy link
Contributor Author

rawkode commented Mar 18, 2020

The linting action doesn't work for v2 charts, but I've tested it locally. We'll force merge it once this has been reviewed

gianarb
gianarb approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@gianarb gianarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!!

@russorat russorat mentioned this pull request Mar 19, 2020
Closed
gitirabassi
gitirabassi approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@gitirabassi gitirabassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!!

@rawkode rawkode merged commit 608b437 into influxdata:master Mar 19, 2020
@rawkode rawkode deleted the feat/influxdb2 branch March 19, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitirabassi gitirabassi gitirabassi approved these changes

@gianarb gianarb gianarb approved these changes

@BondAnthony BondAnthony Awaiting requested review from BondAnthony

@goller goller Awaiting requested review from goller

@russorat russorat Awaiting requested review from russorat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rawkode @naseemkullah @gianarb @goller @russorat @gitirabassi