Allow for raw toml configs for telegraf #358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the delayed response. Could you please rebase, and bump chart version? Thank you. |
There are use cases where we the yaml->toml conversion does not work with the current template. This allows for all the edge cases.
Backwards compatible change
|
I've found that similar config override exists in telegraf-ds since #239, so I've just changed the key for the sake of certain consistency though snake case is used rarely, and added test file for CI. |
powersj
reviewed
Nov 14, 2022
Comment on lines
+156
to
+157
| override_config: | ||
| toml: ~ |
There was a problem hiding this comment.
@alespour - should this really be a tilde or the entire section commented out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are use cases where we the yaml->toml conversion does not work with the current template.
This allows for all the edge cases.